JezzWTF/phokus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: custom TitleBar with window controls (no native decorations) #7

Merged
LyAhn merged 6 commits from feat/custom-titlebar into main 2026-04-06 20:02:45 +00:00
Conversation 2 Commits 6 Files Changed 4
+8 -1
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit aed8fcfd67 - Show all commits
src-tauri/capabilities/default.json
+8 -1
View File
@@ -12,6 +12,13 @@
"fs:allow-read-file",
copilot-pull-request-reviewer[bot] commented 2026-04-06 13:50:42 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

core:window:allow-start-dragging is added to the capability set, but the UI code in this PR doesn’t call startDragging() anywhere (and also doesn’t currently use data-tauri-drag-region). If dragging will be handled via the HTML attribute, consider removing this permission; if dragging will be handled via the API, add the corresponding call in the title bar so the extra permission is justified.
`core:window:allow-start-dragging` is added to the capability set, but the UI code in this PR doesn’t call `startDragging()` anywhere (and also doesn’t currently use `data-tauri-drag-region`). If dragging will be handled via the HTML attribute, consider removing this permission; if dragging will be handled via the API, add the corresponding call in the title bar so the extra permission is justified. ```suggestion ```
"fs:allow-read-dir",
"fs:read-files",
"fs:read-dirs"
"fs:read-dirs",
"core:window:allow-minimize",
"core:window:allow-maximize",
"core:window:allow-unmaximize",
"core:window:allow-close",
"core:window:allow-start-dragging",
copilot-pull-request-reviewer[bot] commented 2026-04-06 13:50:42 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

The capabilities add core:window:allow-maximize and core:window:allow-unmaximize, but the UI code introduced here only calls toggleMaximize() (plus minimize(), close(), isMaximized()). To keep least-privilege, consider removing permissions that aren’t required for the current implementation (unless Tauri’s permission model for toggleMaximize implicitly depends on them).

The capabilities add `core:window:allow-maximize` and `core:window:allow-unmaximize`, but the UI code introduced here only calls `toggleMaximize()` (plus `minimize()`, `close()`, `isMaximized()`). To keep least-privilege, consider removing permissions that aren’t required for the current implementation (unless Tauri’s permission model for `toggleMaximize` implicitly depends on them).
"core:window:allow-toggle-maximize",
"core:window:allow-is-maximized"
]
}