JezzWTF/phokus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: custom TitleBar with window controls (no native decorations) #7

Merged
LyAhn merged 6 commits from feat/custom-titlebar into main 2026-04-06 20:02:45 +00:00
Conversation 2 Commits 6 Files Changed 4
-3
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ab8fba2e3f - Show all commits
src-tauri/capabilities/default.json
-3
View File
1
 @@ -14,10 +14,7 @@
"fs:read-files",
"fs:read-dirs",
"core:window:allow-minimize",
"core:window:allow-maximize",
"core:window:allow-unmaximize",
"core:window:allow-close",
"core:window:allow-start-dragging",
"core:window:allow-toggle-maximize",
"core:window:allow-is-maximized"
]
copilot-pull-request-reviewer[bot] commented 2026-04-06 13:50:42 +00:00 (Migrated from github.com)
Review
Copy Link
Copy Source

The capabilities add core:window:allow-maximize and core:window:allow-unmaximize, but the UI code introduced here only calls toggleMaximize() (plus minimize(), close(), isMaximized()). To keep least-privilege, consider removing permissions that aren’t required for the current implementation (unless Tauri’s permission model for toggleMaximize implicitly depends on them).

The capabilities add `core:window:allow-maximize` and `core:window:allow-unmaximize`, but the UI code introduced here only calls `toggleMaximize()` (plus `minimize()`, `close()`, `isMaximized()`). To keep least-privilege, consider removing permissions that aren’t required for the current implementation (unless Tauri’s permission model for `toggleMaximize` implicitly depends on them).